fix(planet-component): invoke componentRef's destroy when plantCompon…

…entRef dispose (#270)
worktile · Feb 1, 2023 · 73ace3c · 73ace3c
1 parent adeb49f
commit 73ace3c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/packages/planet/src/component/planet-component-loader.spec.ts b/packages/planet/src/component/planet-component-loader.spec.ts
@@ -176,8 +176,10 @@ describe('PlanetComponentLoader', () => {
         registerAppComponents(app1ModuleRef);
         loadApp1Component(app2ModuleRef).subscribe(componentRef => {
             const parent = componentRef.hostElement.parentElement;
+            expect(App1ProjectsComponent.state).toEqual('initialized');
             componentRef.dispose();
             expect(parent.innerHTML).toEqual('');
+            expect(App1ProjectsComponent.state).toEqual('destroyed');
         });
     }));
 });

diff --git a/packages/planet/src/component/planet-component-loader.ts b/packages/planet/src/component/planet-component-loader.ts
@@ -132,6 +132,7 @@ export class PlanetComponentLoader {
             if (appRef.viewCount > 0) {
                 appRef.detachView(componentRef.hostView);
             }
+            componentRef?.destroy();
             componentRootNode.remove();
         };
         return plantComponentRef;

diff --git a/packages/planet/src/testing/app1.module.ts b/packages/planet/src/testing/app1.module.ts
@@ -1,4 +1,4 @@
-import { Component, NgModule } from '@angular/core';
+import { Component, NgModule, OnDestroy } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { PlanetComponentLoader } from '../component/planet-component-loader';
 import { PlanetApplicationLoader } from '../application/planet-application-loader';
@@ -12,7 +12,17 @@ export const app1Name = 'app1';
         projects is work
     `
 })
-export class App1ProjectsComponent {}
+export class App1ProjectsComponent implements OnDestroy {
+    static state: 'initialized' | 'destroyed' | '' = '';
+
+    constructor() {
+        App1ProjectsComponent.state = 'initialized';
+    }
+
+    ngOnDestroy(): void {
+        App1ProjectsComponent.state = 'destroyed';
+    }
+}
 
 @NgModule({
     declarations: [App1ProjectsComponent],