feat(draw): add line resize snapping effect #WIK-14439 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/core/src/utils/math.ts
Outdated
| @@ -316,3 +316,7 @@ export function isVerticalSegment(points: Point[], tolerance: number = 0) { | |||
| export function isPointsOnSameLine(points: Point[], tolerance: number = 0) { | |||
| return isHorizontalSegment(points, tolerance) || isVerticalSegment(points, tolerance); | |||
| } | |||
|
|
|||
| export function getSegmentDirection(points: Point[], tolerance: number = 0): 'x' | 'y' | '' { | |||
There was a problem hiding this comment.
尽量不要这个，用 isHorizontal 表达
| return referencePoint; | ||
| } | ||
|
|
||
| export function getNewResizePoints( |
There was a problem hiding this comment.
可以和以前的一致，叫 alignPoints，另外可以把以前的 alignPoints 挪到 line-resize 里面，名称区分下场景
buffer 和 alignPoints 统一 AlignTolerance
pubuzhixing8
approved these changes
Jan 23, 2024
pubuzhixing8
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.