feat(core): support select group #WIK-14428 #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
huanhuanwa
changed the title
packages/draw/src/utils/group.ts
Outdated
| import { PlaitDrawElement } from '../interfaces'; | ||
| import { PlaitGroup, PlaitGroupElement } from '../interfaces/group'; | ||
|
|
||
| export const getElementsByGroup = (board: PlaitBoard, group: PlaitGroup, recursion?: boolean) => { |
huanhuanwa
changed the title
pubuzhixing8
reviewed
Mar 4, 2024
| PlaitBoard.getElementActiveHost(board).append(selectionMovingG); | ||
| } | ||
| } | ||
| const hitElements = getHitElementsBySelection(board, selection); |
There was a problem hiding this comment.
感觉应该和 selectionRectangleG 一并考虑，放在一个地方通过判断，现在感觉和 selectionRectangleG 割裂了。
pubuzhixing8
reviewed
Mar 5, 2024
| preventTouchMove(board, event, true); | ||
| activeElementsRectangle = getRectangleByElements(board, activeElements, true); | ||
| } else { | ||
| const targetElement = getHitElementByPoint(board, point, el => board.isMovable(el)); | ||
| if (targetElement) { | ||
| startPoint = point; | ||
| activeElements = [targetElement]; | ||
| activeElements = getRelatedElements(board, [targetElement]); |
packages/core/src/utils/group.ts
Outdated
| return result; | ||
| }; | ||
|
|
||
| export const getNewSelectedElements = (board: PlaitBoard, elements: PlaitElement[]) => { |
There was a problem hiding this comment.
getNewSelectedElements 代表什么
packages/core/src/utils/group.ts
Outdated
| return newSelectedElements; | ||
| }; | ||
|
|
||
| export const getCommonElements = (board: PlaitBoard, elements: PlaitElement[]) => { |
pubuzhixing8
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.