-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#wik 14664 #766
#wik 14664 #766
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/draw/src/utils/hit.ts
Outdated
const isHitTextRectangle = RectangleClient.isPointInRectangle(textClient, point); | ||
if (isHitTextRectangle) { | ||
return isHitTextRectangle; | ||
} | ||
} | ||
} | ||
if (PlaitDrawElement.isImage(element) || PlaitDrawElement.isLine(element)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉把 line 的处理从 isRectangleHitDrawElement 单独提出处理更好一些,起一个名字语义化可以对的上了
} | ||
} | ||
if (PlaitDrawElement.isImage(element) || PlaitDrawElement.isLine(element)) { | ||
return isRectangleHitDrawElement(board, element, { anchor: point, focus: point }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以改下名字了,isHitRectangle
No description provided.