fix(common): fix the issue of inconsistent element order when pasting #WIK-15106 #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const newGroup = { ...updateGroupId(item, undefined), id: idCreator() }; | ||
| elements.push(newGroup); |
There was a problem hiding this comment.
这里以前是直接 push 现在是 splice ，而且感觉这里的 item 是不是可能在数组中找不到啊，是不是会产生混乱，后面的函数里也是类似
There was a problem hiding this comment.
- push 换成 splice 是为了在指定 index 插入，上一版提交的代码忘记处理不在分组中的元素了，刚又提了下
- 复制的时候会把所有元素包含分组都放到 clipboardData 中，而 item 是在 clipboardData 中找的，所以一定会找到
pubuzhixing8
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.