feat(core): support alt key duplicate #WIK-15159 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MissLixf
reviewed
Apr 26, 2024
| pendingNodesG = createG(); | ||
| pendingNodesG.classList.add(ACTIVE_MOVING_CLASS_NAME); | ||
| } | ||
| pendingNodesG!.append(movingG); |
|
|
||
| export function withMoving(board: PlaitBoard) { | ||
| const { pointerDown, pointerMove, globalPointerUp, globalPointerMove } = board; | ||
| const { pointerDown, pointerMove, globalPointerUp, globalPointerMove, globalKeyDown, keyUp, pointerUp } = board; |
There was a problem hiding this comment.
对于 duplicated 感觉可以和 with-moving 分开，没必要一起考虑，看看拆开是否合理
There was a problem hiding this comment.
也可以拆开，但是重复代码就会很多， pointerDown 中针对 activeElements 的处理逻辑、还有参考线的逻辑都是一样的
pubuzhixing8
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.