-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListRequisitionsRequest referencing the incorrect parent resource type. #39
Conversation
CC @tristanvuong2021 as this clarifies the intended behavior of world-federation-of-advertisers/cross-media-measurement#172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @corbantek, @oliver-amzn, and @zachcwc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, thanks for fixing that. Looked at this the other and was thinking "that doesn't look right but who knows, maybe it is"
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @corbantek and @zachcwc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @SanjayVas, and @zachcwc)
src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto, line 50 at r1 (raw file):
// for the authenticated user. For example, attempting to list // `Requisition`s for other `DataProvider`s or for `Measurements`s
is a dataprovider allowed to use wildcardID to list all requisitions of a measurement? if not, then the description is not clear I guess.
891f4b0
to
1a28f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @wangyaopw, and @zachcwc)
src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto, line 50 at r1 (raw file):
Previously, wangyaopw (Yao Wang) wrote…
// for the authenticated user. For example, attempting to list // `Requisition`s for other `DataProvider`s or for `Measurements`s
is a dataprovider allowed to use wildcardID to list all requisitions of a measurement? if not, then the description is not clear I guess.
The MC is allowed to do that. The EDP is not, as it would result in Requisitions that belong to other EDPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @corbantek and @zachcwc)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)