Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListRequisitionsRequest referencing the incorrect parent resource type. #39

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Aug 4, 2021

This change is Reviewable

@SanjayVas
Copy link
Member Author

CC @tristanvuong2021 as this clarifies the intended behavior of world-federation-of-advertisers/cross-media-measurement#172

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek, @oliver-amzn, and @zachcwc)

tristanvuong2021 added a commit to world-federation-of-advertisers/cross-media-measurement that referenced this pull request Aug 4, 2021
Copy link

@oliver-amzn oliver-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, thanks for fixing that. Looked at this the other and was thinking "that doesn't look right but who knows, maybe it is"

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek and @zachcwc)

Copy link
Member

@wangyaopw wangyaopw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @SanjayVas, and @zachcwc)


src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto, line 50 at r1 (raw file):

  // for the authenticated user. For example, attempting to list
  // `Requisition`s for other `DataProvider`s or for `Measurements`s

is a dataprovider allowed to use wildcardID to list all requisitions of a measurement? if not, then the description is not clear I guess.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @wangyaopw, and @zachcwc)


src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto, line 50 at r1 (raw file):

Previously, wangyaopw (Yao Wang) wrote…
  // for the authenticated user. For example, attempting to list
  // `Requisition`s for other `DataProvider`s or for `Measurements`s

is a dataprovider allowed to use wildcardID to list all requisitions of a measurement? if not, then the description is not clear I guess.

The MC is allowed to do that. The EDP is not, as it would result in Requisitions that belong to other EDPs.

Copy link
Member

@wangyaopw wangyaopw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek and @zachcwc)

@SanjayVas SanjayVas merged commit fc4667a into main Aug 4, 2021
@SanjayVas SanjayVas deleted the sanjayvas-list-requisitions branch August 4, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants