Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpannerWriter.execute takes in a misleading clock parameter. #243

Closed
SanjayVas opened this issue Aug 31, 2021 · 0 comments · Fixed by #250
Closed

SpannerWriter.execute takes in a misleading clock parameter. #243

SanjayVas opened this issue Aug 31, 2021 · 0 comments · Fixed by #250
Assignees
@tristanvuong2021

Comments

@SanjayVas
Copy link
Member

The execute method of SpannerWriter has a misleading clock parameter, which is used to construct a SpannerWriter.TransactionScope. It is used neither to set the timestamp bound of the transaction nor has any impact on commit timestamps. Instead, it appears to only be used to populate the timestamps in ExchangeStepAttemptDetails.

This parameter should be dropped. It can be passed to subclass constructor in cases where it's really needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tristanvuong2021 tristanvuong2021

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SanjayVas @tristanvuong2021