Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set participant_child_reference_id for claimWork log entries. #1683

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@SanjayVas SanjayVas requested a review from renjiezh July 8, 2024 22:15
@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-log-entry-mill-id branch from 0689129 to 0b1ec77 Compare July 8, 2024 22:17
Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/duchy/service/internal/computations/ComputationsService.kt line 362 at r1 (raw file):

  }

  private fun newCreateComputationLogEntryRequest(

There is a postgres implementation of it in
src/main/kotlin/org/wfanet/measurement/duchy/deploy/common/postgres/PostgresComputationsService.kt

@SanjayVas SanjayVas force-pushed the sanjayvas-log-entry-mill-id branch from 0b1ec77 to 848788f Compare July 9, 2024 18:41
@SanjayVas SanjayVas requested a review from renjiezh July 9, 2024 18:42
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @renjiezh)


src/main/kotlin/org/wfanet/measurement/duchy/service/internal/computations/ComputationsService.kt line 362 at r1 (raw file):

Previously, renjiezh wrote…

There is a postgres implementation of it in
src/main/kotlin/org/wfanet/measurement/duchy/deploy/common/postgres/PostgresComputationsService.kt

Good catch! Done and updated test.

Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-log-entry-mill-id branch from 1d25d3b to fc4e1ab Compare July 16, 2024 17:23
@SanjayVas SanjayVas force-pushed the sanjayvas-log-entry-mill-id branch from fc4e1ab to 81a5d81 Compare July 16, 2024 17:25
@SanjayVas SanjayVas enabled auto-merge (squash) July 16, 2024 17:25
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit 234968b into main Jul 16, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-log-entry-mill-id branch July 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants