Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/49 add pagination component #65

Merged
merged 84 commits into from
Dec 4, 2022

Conversation

Zoe-Bot
Copy link
Contributor

@Zoe-Bot Zoe-Bot commented Nov 20, 2022

Close #49

  • Pagination hook
  • Pagination component
  • Replace current pagination logic in weights index
  • Pagination tests
  • Fix pipeline issue
  • Test mock with ssr
    ACHTUNG: ALLE BUG FINDINGS MIT GEGENTEST BELEGEN!!!!
  • Fix bug with left dots (sollte punkte erst ab 3er seite anzeigen, nicht wenn für die 2 Seite noch platz ist)
  • Mobile only two buttons, tablet icons without text
  • Make sibling count responsive and change to not be prop --> issue
  • Rename all dataCy to datacy cause of warning
  • Add mock server to pipeline => Würde ich nicht machen, die tests müssen einfach mit den Fixtures von Cypress laufen
  • So wieder machen das: /weights?page=1 => /weights war implementiert. ADD TEST FOR THIS
  • Hover auf pages fehlt

@Zoe-Bot Zoe-Bot added this to the Sprint 2 milestone Nov 20, 2022
@Zoe-Bot Zoe-Bot self-assigned this Nov 20, 2022
@Zoe-Bot Zoe-Bot linked an issue Nov 20, 2022 that may be closed by this pull request
@coffeemakingtoaster
Copy link
Contributor

@Zoe-Bot
Please notify me once the feature itself is done so we can tackle the pipeline issue.
And quick question:
Would it be possible to put the e2e application mocking the backend on port 3001 (like the actual backend in dev setup) or 3002 to avoid collision?

@Zoe-Bot
Copy link
Contributor Author

Zoe-Bot commented Nov 21, 2022

@Zoe-Bot Please notify me once the feature itself is done so we can tackle the pipeline issue. And quick question: Would it be possible to put the e2e application mocking the backend on port 3001 (like the actual backend in dev setup) or 3002 to avoid collision?

This fix the mocked test but the normal test with just visiting the page is failing in pipeline. But is working local in both ui and cli.

@coffeemakingtoaster
Copy link
Contributor

@Zoe-Bot Please notify me once the feature itself is done so we can tackle the pipeline issue. And quick question: Would it be possible to put the e2e application mocking the backend on port 3001 (like the actual backend in dev setup) or 3002 to avoid collision?

This fix the mocked test but the normal test with just visiting the page is failing in pipeline. But is working local in both ui and cli.

This may be an issue with the cypress GitHub action setup, I will investigate

@coffeemakingtoaster
Copy link
Contributor

@Zoe-Bot
Fixed easy peasy

Copy link
Contributor

@LarsFlieger LarsFlieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally done! Good work :)

Copy link
Contributor

@coffeemakingtoaster coffeemakingtoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nochmal prüfen ob giga console log nötig ist, sonst fine

frontend/cypress.config.ts Outdated Show resolved Hide resolved
@Zoe-Bot Zoe-Bot merged commit b66d34d into main Dec 4, 2022
@Zoe-Bot Zoe-Bot deleted the feature/49-add-pagination-component branch December 4, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pagination Component
3 participants