Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub Actions #42

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Set up GitHub Actions #42

merged 9 commits into from
Feb 2, 2024

Conversation

elbeejay
Copy link
Contributor

@elbeejay elbeejay commented Jan 22, 2024

Set up some GitHub actions starting with a simple continuous integration workflow to try installing the GOSTnets package on the 3 major operating systems (Linux, Windows, MacOS) for Python 3.8 and then running Python -c import GOSTnets as a very basic test of the package having installed and existing.

Right now we are limited to Python 3.8 because of the hard-pinned dependency rtree-0.9.3 per the project's readme.

@g4brielvs g4brielvs self-requested a review January 23, 2024 03:45
@elbeejay elbeejay marked this pull request as ready for review January 23, 2024 23:18
Copy link
Member

@g4brielvs g4brielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elbeejay Thank you for opening this PR. While this testing workflow can go in parallel, I'd recommend migrating to pyproject.toml first (#40 and #41), including the dependencies and optional dependencies. For example, in the new setup, the dependencies can be added and pinned and the installation could be simplified to pip install gostnets or pip install "gostnets[optimization]" (or even include all dependencies by default because they are not large). Then this PR can be updated and merged. What are your thoughts?

Additionally, the documentation, tests and release workflow (e.g., BlackMarblePy) can also be prioritized. If you agree with the course of action, could you please create and prioritize these as tasks?

@g4brielvs g4brielvs added the enhancement New feature or request label Jan 29, 2024
@elbeejay
Copy link
Contributor Author

@elbeejay Thank you for opening this PR. While this testing workflow can go in parallel, I'd recommend migrating to pyproject.toml first (#40 and #41), including the dependencies and optional dependencies. For example, in the new setup, the dependencies can be added and pinned and the installation could be simplified to pip install gostnets or pip install "gostnets[optimization]" (or even include all dependencies by default because they are not large). Then this PR can be updated and merged. What are your thoughts?

Sure, I'd just started here because the PEP stuff wasn't clear to me (from here) but now that we've cleared that up I can set up the pyproject.toml.

@g4brielvs
Copy link
Member

@elbeejay #40 is now closed.

@elbeejay
Copy link
Contributor Author

elbeejay commented Feb 2, 2024

Added a "publish" workflow for automatic publishing to pypi. May requre configuration on the pypi side per this document

@g4brielvs g4brielvs merged commit db3532d into main Feb 2, 2024
3 checks passed
g4brielvs pushed a commit that referenced this pull request Feb 2, 2024
* add basic ci/cd workflow to test install

* fix location of actions workflow

* fix matrix for os and python version

* print conda python version

* Update build.yml

* python3.8 for ci

* use local pip install for cicd

* add publish workflow
@g4brielvs
Copy link
Member

g4brielvs commented Feb 2, 2024

Added a "publish" workflow for automatic publishing to pypi. May requre configuration on the pypi side per this document

@elbeejay Thanks! Merging (we can open other PRs to complement this basic setip). FYI I have requested a worldbank organization on PyPI, but I'll add it manually in the meantime in the next release.

@g4brielvs g4brielvs deleted the basic-cicd branch March 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants