Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove component that shows pages before and after search result #27

Closed
blackforestboi opened this issue May 29, 2017 · 2 comments
Closed

Remove component that shows pages before and after search result #27

blackforestboi opened this issue May 29, 2017 · 2 comments
Assignees
@poltak
Labels
Prio 1
Projects
Re-launch Release

Comments

@blackforestboi
Copy link
Member

blackforestboi commented May 29, 2017 •
edited by WorldBrain-syncboy

When searching it always shows 2 pages that have been visited before and 2 pages that have been visited after. From a design and UX perspective it is not a worked out feature yet and needs some more work.

Hence, I would suggest we remove/disable the feature for now.
@blackforestboi blackforestboi mentioned this issue May 29, 2017
Closed
18 tasks
poltak added a commit that referenced this issue Jun 13, 2017
@poltak
Ignore visits context logic on search
3ebb8b5 
- fixes issue #27
- code still exists for that; just explicitly changes the flag to ignore them for now
@poltak poltak mentioned this issue Jun 13, 2017
Closed
@blackforestboi
Copy link
Member Author

is this done?

@poltak
Copy link
Member

poltak commented Jun 22, 2017

Yup! 3ebb8b5

@poltak poltak closed this as completed Jun 22, 2017
@blackforestboi blackforestboi added this to Done! Yeah! in Re-launch Release Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poltak poltak

Labels
Prio 1
Projects
No open projects
Re-launch Release
Done! Yeah!
Milestone
No milestone
Development

No branches or pull requests
3 participants
@poltak @blackforestboi @WorldBrain-syncboy