feat(Tracing): use NoopTracer by default #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@camilledejoye do you want to rebase this? |
cdaguerre
force-pushed
the
master
branch
3 times, most recently
from
80cb469
to
a8ef73a
Compare
cdaguerre
force-pushed
the
master
branch
2 times, most recently
from
633595f
to
cee36ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we don't provide a tracer provider to the
Tracingclass when we try to trace something we got an exception.This forces us to configure the
Tracingclass in our unit tests to avoid this exception.This PR propose to use the
NoopTracerprovided by open telemetry instead.In addition I also propose to always use the same tracer instance instead of creating a new one every time, it's already what open telemetry does as we can see with the
NoopTracer::getInstance().