Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-bit wav file support #71

Merged
merged 4 commits into from Mar 21, 2015
Merged

24-bit wav file support #71

merged 4 commits into from Mar 21, 2015

Conversation

sg3510
Copy link
Contributor

@sg3510 sg3510 commented Feb 26, 2015

I use a mix of mp3 and wav files and a minor annoyance is that all my 24-bit wav files fail to be read (pydub relies on the wave module from stdlib - which doesn't support 24 bit wav).

For anyone also trying to use 24 bit files, my fix is to use wavio from @WarrenWeckesser.

I've tested this on my own files and it seems to work without hickups.

@sg3510 sg3510 changed the title Wav 24 bit 24-bit wav files support Feb 26, 2015
@sg3510 sg3510 changed the title 24-bit wav files support 24-bit wav file support Feb 26, 2015
@worldveil
Copy link
Owner

@sg3510 this is great! I just ran a test with normal 16-bit wav files and everything still works.

My only question is how one might install wavio -- is the only way to clone @WarrenWeckesser's github?

@sg3510
Copy link
Contributor Author

sg3510 commented Mar 2, 2015

Right now I've just copied the wavio.py file to the dejavy repo so everything should just work out of the box, however if we want to do it more 'properly' its possible to add wavio as a submodule (and we'd be able to easily import changes to wavio if its updated).

This creates it in a seperate folder (as well as create a .gitmodules to reference it) so I'd probably also have to either:

  • submit a pull request to wavio to add a __init__.py file to do a relative import
  • or just do (some people may not like it due to 'polluting' the namespace but for wavio I dont think its a problem):
import sys
sys.path.append("wavio/")

Is this what you're looking for?

@mostafazh
Copy link

how about we add

pip install git+git://github.com/WarrenWeckesser/wavio.git

to the requirements.txt ?

worldveil added a commit that referenced this pull request Mar 21, 2015
@worldveil worldveil merged commit 1fe7d4f into worldveil:master Mar 21, 2015
yunpengn pushed a commit to yunpengn/dejavu that referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants