Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana: Add error handling on mul_div function #310

Merged
merged 4 commits into from
Apr 9, 2024
Merged

solana: Add error handling on mul_div function #310

merged 4 commits into from
Apr 9, 2024

Conversation

johnsaigle
Copy link
Collaborator

No description provided.

@johnsaigle johnsaigle force-pushed the solana/quoter-err-handling branch 3 times, most recently from 9f9f97b to eedb29e Compare March 19, 2024 16:26
@nik-suri nik-suri added the solana Change to Solana programs label Mar 25, 2024
@johnsaigle johnsaigle added the abi Changes Contract ABI label Mar 26, 2024
@johnsaigle johnsaigle force-pushed the solana/quoter-err-handling branch 2 times, most recently from a47aaa8 to 42682bc Compare March 28, 2024 17:52
@johnsaigle johnsaigle added the blocks release Security issue, major bug, or essential feature to resolve ASAP label Mar 28, 2024
@johnsaigle johnsaigle force-pushed the solana/quoter-err-handling branch 2 times, most recently from 6ff5d4c to df3cd50 Compare April 3, 2024 18:21
a5-pickle
a5-pickle previously requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one nit

a5-pickle
a5-pickle reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I requested changes. But changed this to just a comment. Up to you if you want to make a change.

@a5-pickle a5-pickle dismissed their stale review April 3, 2024 21:03

Fat finger

@johnsaigle johnsaigle force-pushed the solana/quoter-err-handling branch 3 times, most recently from 6e60754 to 880a26c Compare April 5, 2024 16:45
@johnsaigle johnsaigle mentioned this pull request Apr 9, 2024
Merged
@johnsaigle johnsaigle merged commit d555365 into wormhole-foundation:main Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsongor kcsongor kcsongor approved these changes

@a5-pickle a5-pickle a5-pickle approved these changes

@nonergodic nonergodic Awaiting requested review from nonergodic

Assignees
No one assigned
Labels
abi Changes Contract ABI blocks release Security issue, major bug, or essential feature to resolve ASAP solana Change to Solana programs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnsaigle @kcsongor @a5-pickle @nik-suri