Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: Make initialiser payable to allow WH transceiver registration #335

Merged
merged 1 commit into from
Apr 3, 2024
Merged

evm: Make initialiser payable to allow WH transceiver registration #335

merged 1 commit into from
Apr 3, 2024

Conversation

djb15
Copy link
Collaborator

@djb15 djb15 commented Mar 22, 2024

We don't query the wormhole message fee to save gas. The call will revert if the fee amount is not exact.

@djb15 djb15 linked an issue Mar 22, 2024 that may be closed by this pull request
evm: Query Wormhole fee instead of hardcoding to 0 #281
Closed
johnsaigle
johnsaigle approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good but I don't think I have the complete context for understanding the change. I'll defer to other reviewers here if they raise issues

@nik-suri nik-suri added abi Changes Contract ABI evm Change to EVM Contracts labels Mar 25, 2024
mdulin2
mdulin2 previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@mdulin2 mdulin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added it to all of the proper locations. So, I think it's solid and ready to go.

evm/src/NttManager/NttManager.sol Show resolved Hide resolved
@johnsaigle johnsaigle self-requested a review April 3, 2024 18:24
johnsaigle
johnsaigle previously requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a conflict with main

@djb15 djb15 force-pushed the wormhole-fee-on-init branch 2 times, most recently from 56e8c98 to 0eb8963 Compare April 3, 2024 19:04
@djb15 djb15 merged commit 2a0fd86 into main Apr 3, 2024
4 checks passed
@djb15 djb15 deleted the wormhole-fee-on-init branch April 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsaigle johnsaigle johnsaigle approved these changes

@RahulMaganti47 RahulMaganti47 RahulMaganti47 approved these changes

@mdulin2 mdulin2 mdulin2 left review comments

@gator-boi gator-boi Awaiting requested review from gator-boi

Assignees
No one assigned
Labels
abi Changes Contract ABI evm Change to EVM Contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evm: Query Wormhole fee instead of hardcoding to 0
5 participants
@djb15 @johnsaigle @RahulMaganti47 @mdulin2 @nik-suri