evm: Explicitly check staticcalls

[djb15]

No description provided.

[mdulin2]

Can you check the result on this one as well -

example-native-token-transfers/evm/test/libraries/NttManagerHelpers.sol

Line 20 in fb39daa

address(nttManager.token()).staticcall(abi.encodeWithSignature("decimals()"));

[mdulin2]

Add the check in the other location and I think it's good to go.

[RahulMaganti47]

can you add a negative test for this? otherwise, lgtm

[RahulMaganti47]

Can you check the result on this one as well -

example-native-token-transfers/evm/test/libraries/NttManagerHelpers.sol

Line 20 in fb39daa

address(nttManager.token()).staticcall(abi.encodeWithSignature("decimals()"));

might be nice to add but probably not necessary since this is in the tests (unless that error is being tested specifically)?

[mdulin2]

Can you check the result on this one as well -

example-native-token-transfers/evm/test/libraries/NttManagerHelpers.sol

Line 20 in fb39daa

address(nttManager.token()).staticcall(abi.encodeWithSignature("decimals()"));

might be nice to add but probably not necessary since this is in the tests (unless that error is being tested specifically)?

Ahh, you're right. I didn't see this was in the tests - I just saw library and figured it was under the hood.