Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination seems to be broken in GET /api/v1/governor/notional/available/{chainId} #162

Closed
agodnic opened this issue Feb 23, 2023 · 1 comment
Closed

Pagination seems to be broken in GET /api/v1/governor/notional/available/{chainId} #162

agodnic opened this issue Feb 23, 2023 · 1 comment
Labels
api Api component

Comments

@agodnic
Copy link
Contributor

agodnic commented Feb 23, 2023

Reported by @PabloZimmermann
@agodnic agodnic added the api Api component label Feb 23, 2023
@agodnic agodnic changed the title Pagination seems to be broken in GET /api/v1/governor/notional/available/{n} Pagination seems to be broken in GET /api/v1/governor/notional/available/{chainId} Feb 24, 2023
agodnic pushed a commit that referenced this issue Feb 24, 2023
[API] Fix paging in GetAvailableNotionalByChainID
dc73611 
Tracking issue: #162

Changes:
* Fix `page` and `pageSize` parameters in `GET /api/v1/governor/notional/available/{chainId}`.
* Sort results by ascending guardian address to enforce deterministic output.
@agodnic agodnic mentioned this issue Feb 24, 2023
Merged
agodnic added a commit that referenced this issue Mar 1, 2023
@agodnic
[API] Fix pagination in `GET /api/v1/governor/notional/available/{cha…
b3ec0bc 
…inId}` (#168)

### Summary

Changes:
* Fix `page` and `pageSize` parameters in `GET /api/v1/governor/notional/available/{chainId}`.
* Sort results by ascending guardian address to enforce deterministic output.

Tracking issue: #162
@agodnic
Copy link
Contributor Author

agodnic commented Mar 1, 2023

Fixed in #168

@agodnic agodnic closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Api component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agodnic