Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate token database #344

Closed
agodnic opened this issue May 23, 2023 · 0 comments · Fixed by #356
Closed

Deduplicate token database #344

agodnic opened this issue May 23, 2023 · 0 comments · Fixed by #356
Assignees
@agodnic
Labels
enhancement New feature or request v1 v1 release

Comments

@agodnic
Copy link
Contributor

agodnic commented May 23, 2023

Description

The analytics and backfiller components are using different token databases. Unify those into a single package.
@agodnic agodnic added enhancement New feature or request v1 v1 release labels May 23, 2023
@agodnic agodnic self-assigned this May 29, 2023
@agodnic agodnic linked a pull request May 29, 2023 that will close this issue
Remove duplicated code in token database #356
Merged
@agodnic agodnic mentioned this issue May 29, 2023
Merged
agodnic added a commit that referenced this issue May 30, 2023
@agodnic
Remove duplicated code in token database (#356)
37d6d42 
### Summary

Tracking issue: #344

Before this pull request, there were two separate token databases (one being used by the InfluxDB backfiller, and another one in the `common/` module being used by the analytics service).

Having two different token databases resulted in inconsistencies, due to each of these databases containing different tokens.

This PR unifies those two databases into a single one, under the `common/` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agodnic agodnic

Labels
enhancement New feature or request v1 v1 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated code in token database wormhole-foundation/wormhole-explorer
1 participant
@agodnic