Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction detail page never loads #430

Closed
hernandiegosavio opened this issue Jun 20, 2023 · 4 comments
Closed

Transaction detail page never loads #430

hernandiegosavio opened this issue Jun 20, 2023 · 4 comments
Assignees
@agodnic
Labels
bug Something isn't working v1 v1 release
Milestone
v1

Comments

@hernandiegosavio
Copy link
Collaborator

When you got from the transaction list to a particular transaction detail, page is not loading

E.g

https://front.staging.wormscan.io/#/tx/0x628f04bdda072cbf84e3bf7c36d2e54bb7a9df51bbd3fd5a1707964e69c45c54
@hernandiegosavio hernandiegosavio added the bug Something isn't working label Jun 20, 2023
@agodnic
Copy link
Contributor

agodnic commented Jun 20, 2023 •
edited

I believe this happens specifically for VAAs emitted in the Aptos blockchain. Let us know If you run into the same issue with a different emitter chain.

This can be fixed by adding special logic for Aptos in the database query that handles the search. We used a similar workaround for Solana.

@agodnic agodnic added the v1 v1 release label Jun 20, 2023
@agodnic agodnic added this to the v1 milestone Jun 20, 2023
@agodnic agodnic changed the title Transaction detail never load Transaction detail page never loads Jun 21, 2023
This was referenced Jun 24, 2023
Closed
Merged
@agodnic
Copy link
Contributor

agodnic commented Jun 26, 2023 •
edited

Fixed in #461, but not deployed yet.

agodnic added a commit that referenced this issue Jun 27, 2023
@agodnic
Fix transaction hash search for Aptos (#461)
5663fed 
### Description

Tracking issue: #430

In `GET /api/v1/vaas?txHash={hash}`, searching for Aptos VAAs by transaction hash was not working correctly. This pull request fixes the issue.
@SamantaCasal
Copy link
Collaborator

@agodnic I think this is already solved, is it correct?
Evidence:

@agodnic
Copy link
Contributor

agodnic commented Jul 4, 2023

Yes, I believe the patch was deployed recently.

@agodnic agodnic closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agodnic agodnic

Labels
bug Something isn't working v1 v1 release
Projects
None yet
Milestone
v1
Development

No branches or pull requests
3 participants
@agodnic @SamantaCasal @hernandiegosavio