Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /api/v1/vaas error: expected at most one transaction #493

Closed
agodnic opened this issue Jul 3, 2023 · 1 comment
Closed

GET /api/v1/vaas error: expected at most one transaction #493

agodnic opened this issue Jul 3, 2023 · 1 comment
Assignees
Labels
api Api component bug Something isn't working

Comments

@agodnic
Copy link
Contributor

agodnic commented Jul 3, 2023

Description

When there's more than one VAA with the same transaction hash, the endpoint GET /api/v1/vaas?txHash={hash} returns:

{
  "code": 13,
  "message": "INTERNAL ERROR",
  "details": [
    {
    "request_id": "5822cc4d-3ff0-4046-ac0c-ccffcd3948bc",
    "stack_trace": "expected at most one transaction, but found 2\n"
    }
  ]
}

Instead, it should just return the VAAs.

Example: https://api.staging.wormscan.io/api/v1/vaas/?txHash=bc7f513abbcf749e95aaeeb09733bf99fa07e9e0fbd62863b59fc012a64f9807&parsedPayload=true

@agodnic agodnic added bug Something isn't working api Api component labels Jul 3, 2023
@agodnic agodnic self-assigned this Jul 4, 2023
agodnic added a commit that referenced this issue Jul 4, 2023
### Description

Tracking issue: #493

Fix an issue in which transaction hash search was failing for VAAs that have the same `txHash`.
@agodnic
Copy link
Contributor Author

agodnic commented Jul 4, 2023

Implemented in #494

@agodnic agodnic closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Api component bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant