Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Inconsistency between the info obtained from /api/v1/x-chain-activity/?timeSpan=7d&by=tx and /api/v1/top-chain-pairs-by-num-transfers?timeSpan=7d for the same chain #535

Closed
SamantaCasal opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
api Api component bug Something isn't working

Comments

@SamantaCasal
Copy link
Collaborator

Environment:
MacBook Pro, macOS Ventura 13.1.1, Chrome Version 113.0.5672.63.
** On STG and PROD**

Steps
1 Go to https://api.staging.wormscan.io/api/v1/x-chain-activity/?timeSpan=7d&by=tx
2 Look for the txs of the chain 22
3 go to
https://api.staging.wormscan.io/api/v1/top-chain-pairs-by-num-transfers?timeSpan=7d
4 See the results of the chain 22
5 Compare the number of transactions produced by each endpoint

Obtained result:
The https://api.staging.wormscan.io/api/v1/top-chain-pairs-by-num-transfers?timeSpan=7d endpoint seems to be "behind" the info that comes in the https endpoint: //api.staging.wormscan.io/api/v1/x-chain-activity/?timeSpan=7d&by=tx

Note: this difference causes us to display inconsistent data on https://front.staging.wormscan.io/#/

Expected result:
Endpoints should return the same information about the specified string.

Evidence:

https://github.com/wormhole-foundation/wormhole-explorer/assets/69044575/30497063-c9f1-4a1c-8b2f-67470d402f02
Image
Image

@SamantaCasal SamantaCasal added api Api component bug Something isn't working labels Jul 13, 2023
@agodnic agodnic self-assigned this Jul 17, 2023
agodnic added a commit that referenced this issue Jul 19, 2023
### Description

Tracking issue: #535.

This pull request fixes an inconsistency between the endpoints `GET /api/v1/x-chain-activity` and `GET /api/v1/top-chain-pairs-by-num-transfers`.

The inconsistency arose because the endpoints computed the data in slightly different ways.

It was resolved by modifying the `GET /api/v1/top-chain-pairs-by-num-transfers` endpoint to use the same data source as `GET /api/v1/x-chain-activity`.
@agodnic
Copy link
Contributor

agodnic commented Jul 19, 2023

This hasn't been deployed to staging/production yet.

@SamantaCasal
Copy link
Collaborator Author

QA OK!
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Api component bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants