Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/api/v1/top-chain-pairs-by-num-transfers [Testnet] Get data for a destination chain that doesn't exist #572

Open
SamantaCasal opened this issue Jul 21, 2023 · 0 comments
Open

/api/v1/top-chain-pairs-by-num-transfers [Testnet] Get data for a destination chain that doesn't exist #572

SamantaCasal opened this issue Jul 21, 2023 · 0 comments
Assignees
@agodnic
Labels
api Api component bug Something isn't working

Comments

@SamantaCasal
Copy link
Collaborator

Environment:
MacBook Pro, macOS Ventura 13.1.1, Chrome Version 113.0.5672.63.
Tested in: TESTNET

Steps

  1. Go to https://api.testnet.wormscan.io/api/v1/top-chain-pairs-by-num-transfers?timeSpan=15d
  2. Observe the destination chain of the penultimate pair

Obtained result:
Shows a destination chain that does not correspond to any active chain as listed at https://github.com/wormhole-foundation/wormhole/blob/main/sdk/vaa/structs.go

Expected result:
Should return a valid destination chain

Evidence:

Image
@SamantaCasal SamantaCasal added api Api component bug Something isn't working labels Jul 21, 2023
@agodnic agodnic self-assigned this Jul 21, 2023
@agodnic agodnic mentioned this issue Jul 21, 2023
Merged
agodnic added a commit that referenced this issue Jul 24, 2023
@agodnic
Exclude invalid chain IDs from top chain pairs (#574)
4ee9abe 
### Description

Tracking issues: #572, #573

This pull request fixes an issue in which the endpoint `GET /api/v1/top-chain-pairs-by-num-transfers` was returning invalid chain IDs for testnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agodnic agodnic

Labels
api Api component bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agodnic @SamantaCasal