node/watchers/evm: do not allow finalizer == nil (TOB-WORMGUWA-17)

wormhole-foundation · May 4, 2023 · 271b815 · 271b815
1 parent 8938c22
commit 271b815
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/node/pkg/watchers/evm/connectors/poller.go b/node/pkg/watchers/evm/connectors/poller.go
@@ -143,17 +143,15 @@ func (b *BlockPollConnector) pollBlocks(ctx context.Context, logger *zap.Logger,
 			return lastPublishedBlock, fmt.Errorf("failed to fetch next block (%d): %w", nextBlockNumber.Uint64(), err)
 		}
 
-		if b.finalizer != nil {
-			finalized, err := b.isBlockFinalizedWithTimeout(ctx, block)
-			if err != nil {
-				logger.Error("failed to check block finalization",
-					zap.Uint64("block", block.Number.Uint64()), zap.Error(err))
-				return lastPublishedBlock, fmt.Errorf("failed to check block finalization (%d): %w", block.Number.Uint64(), err)
-			}
+		finalized, err := b.isBlockFinalizedWithTimeout(ctx, block)
+		if err != nil {
+			logger.Error("failed to check block finalization",
+				zap.Uint64("block", block.Number.Uint64()), zap.Error(err))
+			return lastPublishedBlock, fmt.Errorf("failed to check block finalization (%d): %w", block.Number.Uint64(), err)
+		}
 
-			if !finalized {
-				break
-			}
+		if !finalized {
+			break
 		}
 
 		b.blockFeed.Send(block)