Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum proxy #13

Closed
hendrikhofstadt opened this issue Aug 24, 2020 · 1 comment
Closed

Ethereum proxy #13

hendrikhofstadt opened this issue Aug 24, 2020 · 1 comment
Assignees
@hendrikhofstadt
Labels
enhancement New feature or request
Milestone
v1

Comments

@hendrikhofstadt
Copy link
Contributor

hendrikhofstadt commented Aug 24, 2020 •
edited by leoluk

https://github.com/certusone/wormhole/blob/e0533c70c5483a5e88fdd2bba9e12182c22d0f7b/ethereum/contracts/Wormhole.sol#L4

We'll need a delegatecall proxy in front of the Ethereum bridge to allow upgrades.
The upgrades will be implemented as VAA 0x02 - UpgradeEthereumBridge.
@hendrikhofstadt hendrikhofstadt added the enhancement New feature or request label Aug 24, 2020
@hendrikhofstadt hendrikhofstadt self-assigned this Aug 24, 2020
@leoluk leoluk added this to the v1 milestone Aug 24, 2020
@hendrikhofstadt
Copy link
Contributor Author

We don't actually want to upgrade the bridge contract, new VAA types are unlikely and the risk of mistakes during an upgrade are too high.

When upgrading, we'll need to transfer all assets from the old bridge. We can do this by transfering ~95% of value using all guardians, then upgrading the guardianset to 1 guardian and using that authority to cheaply perform the rest of migration transfers.

@leoluk leoluk mentioned this issue Nov 16, 2020
Closed
drozdziak1 pushed a commit to drozdziak1/wormhole that referenced this issue Mar 6, 2022
Merge pull request wormhole-foundation#13 from pyth-network/p2w-confi…
4944e8b 
…gurability

hotfix readiness thread join, bump pyth Truffle migration to number 5
sekoje pushed a commit that referenced this issue May 18, 2022
Merge pull request #13 from certusone/evm
745d0b5 
Add ownerOnly methods to update certain parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hendrikhofstadt hendrikhofstadt

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1
Development

No branches or pull requests
2 participants
@leoluk @hendrikhofstadt