Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core Bridge Cosmwasm contract to publish IBC Message to wormchain #2198

Closed
nik-suri opened this issue Jan 5, 2023 · 1 comment
Closed
Assignees

Comments

@nik-suri
Copy link
Collaborator

nik-suri commented Jan 5, 2023

Edit the publishMessage function to send an IBC message to wormchain instead of directly emitting a wormhole message on the source chain.

This functionality should ideally be enabled using a compile-time feature flag.

@nik-suri nik-suri added this to the Cosmos IBC Bridging milestone Jan 5, 2023
@nik-suri nik-suri self-assigned this Jan 5, 2023
@jynnantonix
Copy link
Contributor

Unfortunately there's no way to properly do mutually exclusive compile time features in rust in a single crate. Cargo features are supposed to be additive:

A consequence of this is that features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features.

If we want to do this the Right Way (TM) then I think we should have a new "wormhole-ibc" contract that depends on the original core bridge as a library, delegates all the handling to the original core bridge, and then converts any attributes and events from the Response struct into IBC messages that get posted to wormchain.

See the various *-shutdown contracts for examples where we've done something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants