Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibc cosmwasm contracts #2591

Merged
merged 19 commits into from May 18, 2023
Merged

Ibc cosmwasm contracts #2591

merged 19 commits into from May 18, 2023

Conversation

nik-suri
Copy link
Collaborator

@nik-suri nik-suri commented Apr 6, 2023

#2198 #2199

This PR adds the two new cosmwasm contract for IBC generic message emission: wormchain-ibc-receiver and wormhole-ibc. These two contracts implement a custom IBC protocol. The wormhole-ibc contract should be deployed to IBC-enabled chains, and the various wormhole-ibc contract should connect via IBC to the wormchain-ibc-receiver contract, which will live on Wormchain.

For existing Cosmos deployments, the wormhole cosmwasm contract should be migrated to the wormhole-ibc cosmwasm contract after it is uploaded to the chain.

Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

cosmwasm/contracts/wormchain-ibc-receiver/src/ibc.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract/tests.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract/tests.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/ibc.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When @panoel attempted to upgrade the wormhole contract, it failed due to the new versioning checks.

cosmwasm/contracts/wormchain-ibc-receiver/src/contract.rs Outdated Show resolved Hide resolved
@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 9723755 to 686c441 Compare April 13, 2023 14:53
@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 7c666a3 to 12c64c8 Compare April 18, 2023 16:48
@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 7747f55 to bd7e4d8 Compare April 20, 2023 22:52
@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 306f17f to d5c9b6b Compare April 24, 2023 21:11
felix-asym
felix-asym previously approved these changes May 15, 2023
jynnantonix
jynnantonix previously approved these changes May 16, 2023
cosmwasm/contracts/wormchain-ibc-receiver/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/contracts/wormhole-ibc/src/contract/tests.rs Outdated Show resolved Hide resolved
@nik-suri nik-suri dismissed stale reviews from jynnantonix and felix-asym via ce0fe7f May 16, 2023 15:03
@nik-suri nik-suri requested a review from jynnantonix May 16, 2023 15:04
@evan-gray evan-gray requested a review from felix-asym May 16, 2023 18:51
@evan-gray evan-gray dismissed stale reviews from hendrikhofstadt and themself May 17, 2023 14:07

According to @nik-suri changes addressed. They will follow up with tests

@evan-gray evan-gray merged commit 892274f into main May 18, 2023
21 checks passed
@evan-gray evan-gray deleted the ibc-cosmwasm-contracts branch May 18, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants