Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethereum: add check for the zero address in storeGuardianSet #1432

Merged
merged 1 commit into from Sep 15, 2022
Merged

ethereum: add check for the zero address in storeGuardianSet #1432

merged 1 commit into from Sep 15, 2022

Conversation

gator-boi
Copy link
Contributor

@gator-boi gator-boi commented Aug 15, 2022 •
edited by leoluk

This change is Reviewable

add check for the zero address in storeGuardianSet
f56826f 
Change-Id: Ic3c5fce71f687d98380d39dc62923d9c6423e194
@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited

✅ Deploy Preview for tubular-dango-1656b2 ready!

Name Link
🔨 Latest commit f56826f
🔍 Latest deploy log https://app.netlify.com/sites/tubular-dango-1656b2/deploys/62fa6016341b47000860884b
😎 Deploy Preview https://deploy-preview-1432--tubular-dango-1656b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gator-boi gator-boi changed the title add check for the zero address in storeGuardianSet ethereum: add check for the zero address in storeGuardianSet Aug 15, 2022
@tbjump tbjump self-requested a review August 15, 2022 15:17
tbjump
tbjump approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@tbjump tbjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good sanity check to add.

kcsongor
kcsongor approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@kcsongor kcsongor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great patch

@evan-gray evan-gray merged commit 6c6b25a into dev.v2 Sep 15, 2022
@evan-gray evan-gray deleted the evm-address-check branch September 15, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcsongor kcsongor kcsongor approved these changes

@claudijd claudijd claudijd approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@tbjump tbjump tbjump approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gator-boi @kcsongor @claudijd @bruce-riley @tbjump @evan-gray