Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: governor publish gossip #1538

Merged
merged 7 commits into from Sep 26, 2022
Merged

node: governor publish gossip #1538

merged 7 commits into from Sep 26, 2022

Conversation

bruce-riley
Copy link
Contributor

Change-Id: I2b8b1ea84a0c411101a7027acd3a27a6d6464d59

@hendrikhofstadt
Copy link
Contributor

These should be signed such that they can't be spoofed.
Otherwise an attacker can confuse observers on the network that are analyzing enqueued transactions with fake information.

@bruce-riley
Governor publish gossip
8f3b56a 
Change-Id: I2b8b1ea84a0c411101a7027acd3a27a6d6464d59
@bruce-riley
Update the config publish time
feac65d 
Change-Id: Ic6abf84befb1c20756da2ff66b15a8325dc46067
@bruce-riley
Not setting value on enqueued VAAs correctly
691d6b2 
Change-Id: I9fd3a5d8fc574f8382125445fa688efdae45b88c
@bruce-riley
Publish at most 20 VAAs, not 20 per chain
fa8040b 
Change-Id: Ic9dff99c59ee89d57fd79158844a1fe1a0003112
@bruce-riley
Copy link
Contributor Author

Changed to use signed messages, per comment from @hendrikhofstadt.

@bruce-riley
Switch to using signed messages
6ef3880 
Change-Id: I66cddc7477cd477aa77bdadfc346b588f2ae645b
@bruce-riley
Publish status only once per minute
29828ff 
Change-Id: I972fb0cf868e89c6f74ae4441471a55df389f4dd
@bruce-riley
Minor comment change
affa9af 
Change-Id: I0d3e443cbec7edd282f89c1a5cce5d5ec8776d55
@bruce-riley bruce-riley merged commit 2b582b1 into dev.v2 Sep 26, 2022
@bruce-riley bruce-riley deleted the govenor_gossip_publish branch September 26, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckeun ckeun ckeun approved these changes

@panoel panoel panoel approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bruce-riley @hendrikhofstadt @ckeun @panoel