Reobservation rate-limit #1621
Merged
Reobservation rate-limit #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently run the cleanup loop every 30 seconds, which means that once 5 minutes have passed for an observation without quorum we will send out re-observation requests to the p2p network every 30 seconds. This is a bit excessive so limit sending these requests out to once every 5 minutes.
jynnantonix
commented
Sep 20, 2022
The per-watcher channels for reobservation requests don't have a buffer, which means that if sending on any one channel blocks then _all_ reobservation requests get blocked. Make the send fallible and log if it blocks instead.
jynnantonix
force-pushed
the
pr/jynnantonix/rate-limit-reobservations
branch
from
1bbbb8e
to
360811f
Compare
bruce-riley
previously approved these changes
Sep 20, 2022
Change-Id: I59743a605c92bbff82789c5d981dca882be8bbbe
|
Added buffers to chain specific channels so we're not dropping too aggressively |
SEJeff
approved these changes
Sep 20, 2022
hendrikhofstadt
approved these changes
Sep 22, 2022
bruce-riley
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rate-limiting for sending out re-observation requests and also make the receiver non-blocking.