node: don't store pythnet VAAs in the database #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
requested review from
jynnantonix,
evan-gray and
hendrikhofstadt
jynnantonix
reviewed
Sep 26, 2022
Change-Id: Ief4357ab4c909d25dc9182490c322ef253ac23d3
Change-Id: I46efea96d6c2ba65459254ffeb21f5d65abebb01
Change-Id: Ib7f521ecff62b1bd13efcb627f88413f4141de59
Change-Id: I067f8364042f494ad56ed88919cd917f18423073
bruce-riley
force-pushed
the
node/dont_store_pythnet_vaas
branch
from
034294b
to
9e7c073
Compare
jynnantonix
approved these changes
Sep 27, 2022
hendrikhofstadt
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores PythNet VAAs in memory rather than writing them to the guardiand database. It does this for ChainID == Pythnet rather than using the new IsUnreliable flag because that flag is not present in the SignedVAAWithQuorum gossip message (and changing that message might break various things).
Change-Id: Ief4357ab4c909d25dc9182490c322ef253ac23d3