Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilt devnet deployment for ibc generic messaging #2593

Merged
merged 11 commits into from May 18, 2023
Merged

Conversation

nik-suri
Copy link
Collaborator

@nik-suri nik-suri commented Apr 6, 2023

No description provided.

cosmwasm/deployment/terra2/tools/deploy.js Show resolved Hide resolved
cosmwasm/deployment/terra2/tools/deploy.js Outdated Show resolved Hide resolved
cosmwasm/deployment/terra2/tools/deploy.js Show resolved Hide resolved
cosmwasm/deployment/terra2/tools/deploy.js Outdated Show resolved Hide resolved
cosmwasm/deployment/terra2/tools/deploy.js Outdated Show resolved Hide resolved
@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 3075593 to a281dcc Compare April 12, 2023 15:53
@nik-suri nik-suri force-pushed the ibc-devnet-deployment branch 2 times, most recently from 514e903 to 65d6fd5 Compare April 12, 2023 23:03
Copy link
Collaborator

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had anticipated testing the IBC route in addition to the existing core code. Perhaps it is worth considering setting the second, IBC route as a different chain id in devnet. Open to discussion, just concerned about losing a test path.

cosmwasm/deployment/terra2/tools/deploy.js Outdated Show resolved Hide resolved
@bruce-riley
Copy link
Contributor

Rust tests are failing.

@nik-suri nik-suri force-pushed the ibc-cosmwasm-contracts branch 2 times, most recently from 7c666a3 to 12c64c8 Compare April 18, 2023 16:48
@nik-suri nik-suri force-pushed the ibc-devnet-deployment branch 2 times, most recently from fbe3694 to e9148f9 Compare April 20, 2023 14:50
@nik-suri nik-suri force-pushed the ibc-devnet-deployment branch 2 times, most recently from c3e506e to b83594d Compare May 18, 2023 19:49
bruce-riley
bruce-riley previously approved these changes May 18, 2023
Copy link
Collaborator

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of churn to get tilt to pass but you did it! 🙌

@evan-gray evan-gray dismissed kcsongor’s stale review May 18, 2023 22:36

Agree with changing the deploy in the future :) we should make issues for cleaning it up.

@evan-gray evan-gray merged commit f6f93bf into main May 18, 2023
21 checks passed
@evan-gray evan-gray deleted the ibc-devnet-deployment branch May 18, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants