sdk/js: Replace deprecated function with signSendAndConfirmTransaction

[hmzakhalid]

Summary

This pull request addresses the deprecation of the sendAndConfirmTransactionsWithRetry function in the postVaaWithRetry method. This function was replaced with the new signSendAndConfirmTransaction function as per the recent updates in the library. The retries are done with the ConfirmOption and handled internally in the Solana library.

Changes

The main changes involve replacing the deprecated sendAndConfirmTransactionsWithRetry function with the signSendAndConfirmTransaction function in the postVaaWithRetry method. The signSendAndConfirmTransaction function handles each transaction individually, so the code has been adjusted to process each transaction in a loop.

This change was required because sendAndConfirmTransactionsWithRetry was marked as deprecated in the library, and the library maintainers recommended using signSendAndConfirmTransaction instead.

[barnjamin]

@kev1n-peters or @nonergodic can you plz take a peek at this one?

[nonergodic]

Given that the max retries can now be specified via options, isn't the right call here to deprecate postVaaWithRetry entirely? (And let's face it, it should have never existed in the first place.)

[hmzakhalid]

Hey @nonergodic, I'm in complete favor of deprecating the postVaaWithRetry function, as the functionality is identical to postVaa, except for the additional asyncVerifySignatures parameter.

Would this deprecation message suffice?

/**
 * @deprecated Please use {@link postVaa} instead, which allows
 * retries and commitment to be configured in {@link ConfirmOptions}.
*/

[nonergodic]

Looks good to me 👍

[hmzakhalid]

@nonergodic Perfect! I've committed the suggested changes.