Node/spy: Adds optional VAA signature verification #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyuyap
reviewed
Mar 24, 2024
bingyuyap
reviewed
Mar 24, 2024
evan-gray
previously approved these changes
Mar 25, 2024
evan-gray
approved these changes
Mar 25, 2024
panoel
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the spy to support optional verification of VAA signatures. Any VAA that has an invalid signature is dropped.
To use this feature, add the following config parameters.
These values should work for mainnet:
These values should work for Sepolia testnet:
This PR fixes issue #2888.