ethereum: make core contract upgradeable #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcsongor
requested review from
hendrikhofstadt,
calebrate,
evan-gray,
chase-45 and
bruce-riley
and removed request for
calebrate
bruce-riley
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chase-45, @evan-gray, and @hendrikhofstadt)
|
Subsumed by #1272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core bridge Implementation contract currently has no
initialize()method, which means that trying to upgrade to it would revert, since the upgrade logic delegatecallsinitialize:https://github.com/certusone/wormhole/blob/60363dd3d1f19ad55d9100f13c58a5c646d02902/ethereum/contracts/Governance.sol#L96-L97
Just adding it here so it's not forgotten the next time we need to do an upgrade.
This change is