You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like, in case of any error, Galleria retries to load images with a time stamp added with the image URL. Following code is from Galleria.Picture.load
onerror=function(){if(!reload){reload=true;// reload the image with a timestampwindow.setTimeout((function(image,src){returnfunction(){image.attr('src',src+'?'+Utils.timestamp());};}($(this),src)),50);}else{// apply the dummy image if it existsif(DUMMY){$(this).attr('src',DUMMY);}else{Galleria.raise('Image not found: '+src);}}}
This is fine but the function which adds time stamp with the image URL will cause problem if query strings are already there in the URL.
For example if the image URL is like "....../image1.jpg?width=600&height=400" then, on error while loading the image first time, Galleria will add time stamp with the URL and the new URL will be an invalid one "....../image1.jpg?width=600&height=400?xxxxxxxxxxxxx"
It would be great if the Question (?) is added only if no query string is already there in the URL. In additions, I guess it will be better to add the time stamp with a query string name to form URL like.
"....../image1.jpg?width=600&height=400&ts=xxxxxxxxxxxxx"
or
"....../image1.jpg?ts=xxxxxxxxxxxxx"
The text was updated successfully, but these errors were encountered:
It seems like, in case of any error, Galleria retries to load images with a time stamp added with the image URL. Following code is from Galleria.Picture.load
This is fine but the function which adds time stamp with the image URL will cause problem if query strings are already there in the URL.
For example if the image URL is like "....../image1.jpg?width=600&height=400" then, on error while loading the image first time, Galleria will add time stamp with the URL and the new URL will be an invalid one "....../image1.jpg?width=600&height=400?xxxxxxxxxxxxx"
It would be great if the Question (?) is added only if no query string is already there in the URL. In additions, I guess it will be better to add the time stamp with a query string name to form URL like.
"....../image1.jpg?width=600&height=400&ts=xxxxxxxxxxxxx"
or
"....../image1.jpg?ts=xxxxxxxxxxxxx"
The text was updated successfully, but these errors were encountered: