Configurable raise exception on missing templates #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfarrell
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Seems reasonable to me as the settings name.
@mands Could you also update the documentation in the README to reflect this change? Also, please update the CHANGELOG tbd section with this change well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an exception is only raised if debug is
True, however the web app may be built as a container in CD, resulting in the process of generating the templates may be different to local development (we hit this and ended up sending blank emails to all our users as the template was not installed correctly during CD but worked fine locally).This PR adds an additional setting (
HERALD_RAISE_MISSING_TEMPLATES) - it defaults toTruewhich I think may be the safer default.Cheers!