Unpack Components - Non-static Pages #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahurka
force-pushed
the
another-no-components
branch
2 times, most recently
from
c841420
to
f34aba2
Compare
kngai
requested changes
Jun 11, 2020
This was referenced Jun 11, 2020
ahurka
pushed a commit
to ahurka/woudc-ui
that referenced
this pull request
Jun 11, 2020
ahurka
pushed a commit
to ahurka/woudc-ui
that referenced
this pull request
Jun 11, 2020
ahurka
force-pushed
the
another-no-components
branch
from
b0fa991
to
5db0ad0
Compare
Take constants out of global scope Change contributor header translations from lists to objects Change station header translations from lists to objects Change instrument header translations from lists to objects Unpack search page woudc-blurb components Unpack datasets selector and provide translations Unpack search page country selector component Unpack search page station selector component Unpack search page instrument selector component Move selector styles into search page Clean up search page models and add '...' select options Unpack contact page woudc-blurb components Unpack contact page woudc-note components Cleanup contact page models Replace some placeholder translations Finalize non-static page routes Apply pull request woudc#6 suggestions
ahurka
force-pushed
the
another-no-components
branch
from
5db0ad0
to
39aa7fb
Compare
kngai
approved these changes
Jun 11, 2020
ahurka
pushed a commit
to ahurka/woudc-ui
that referenced
this pull request
Jun 18, 2020
Take constants out of global scope Change contributor header translations from lists to objects Change station header translations from lists to objects Change instrument header translations from lists to objects Unpack search page woudc-blurb components Unpack datasets selector and provide translations Unpack search page country selector component Unpack search page station selector component Unpack search page instrument selector component Move selector styles into search page Clean up search page models and add '...' select options Unpack contact page woudc-blurb components Unpack contact page woudc-note components Cleanup contact page models Replace some placeholder translations Finalize non-static page routes Apply pull request woudc#6 suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all occurrences of the woudc-blurb, woudc-note, woudc-link, and woudc-select components and replaces them with straight-up Vue components in any remaning non-static pages in the project.
Mainly affects list-type pages (e.g. contributors list, stations list) and the search page, as well as the contact page. Does not affect the news page or products/dataset info pages; I'm not clear on how those pages will work just yet.
Intended as part of a cleanup of the translation system, so that blurbs are built using readable component substitution rather than being set up behind-the-scenes by all these custom components. So translations in the JSON files and their uses in the Vue components in non-static pages have been cleaned up too.