-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.0 release #595
Comments
The relative values for svg number is an fx internal. There is no need to mention that in the docs except if you want to make relative numbers a feature (I do not suggest that ^^) |
Not sure about the relative value for Agree with all but For 3.0.0 this should be revised. In this case, if we keep I agree it is in line with the The same can be said for the UPDATE |
This change was done to simplify to The relative Numbers are exclusively used in the fx module to make |
Maybe it's better not to document |
Another thought. |
It already does. See this lines: array = array.reduce(function(prev, curr){
return [].concat.apply(prev, curr)
}, []) All arrays are normalized to flat arrays before beeing parsed to a patharray |
Ok, couldn't find it at first sight. Then I'll document that as well. |
There is not really a place for this one:
The corresponding methods on |
Maybe we could mention that |
I think that would be a good idea and since animated method are made to be used the same way as their non-animated counter-part that might be all that is needed to mention. |
Both are fine but I think I will cast my vote on the second one. |
Me too. Let's go for that then. |
@Fuzzyma just a note, but reading the array flatten code: array = array.reduce(function(prev, curr){
return Array.prototype.concat.apply(prev, curr)
}, []) I don't know how hot this code is. If it's only called a few times, then it makes no difference. |
I dont think it makes a big difference but go forward and change it if you like. Actually we can test that with jsperf :D |
Si! But you need a throw a lot of arrays after it to see a difference and last time I tried, jsperf broke. |
Also I don't think the speed will change much, however I expect the memory usage to be quite different. |
In this case I can argue that the array is thrown away in the next run so there is basically only one wasted array in memory every time :) |
@Fuzzyma gotcha |
Here you go: Does not make much of a difference. FF is almost as twice as fast as chrome btw^^ |
@dotnetCarpenter I would like to see #597 on the list for this release. |
We are all no typescript user. We can put this on the list but only if you are willing to provide us with a pr for this |
OK. Sounds reasonable. I will look into the ts side as that is what I am using and open tickets as needed. Seems like the 3.0.0 timeline is more realistic. |
@peterennis in 3.0 there will be api changes again so the ts file wont be up to date anyway. For user of the v2 branch we maybe should fix it, too. Many users wont switch to v3 immediately |
@dotnetCarpenter with #626 all boxes now have a transform function which transforms the box with a given matrix. |
issue with jsfiddle created: jsfiddle/jsfiddle-users#983 |
They already added it - thats great! |
Things that needs to be visited before we release 2.5.0
clone
method to array objects #590Documentation for make the method plot a getter when no parameter is passed for SVG.Polyline,SVG.Polygon, SVG.Line, SVG.Path (related Sort out leftovers from the old fx module #547)SVG.PointArray
to be passed flat arrayDocumentation for allow plot to be called with 4 parameters when animating an SVG.LineDocumentation for relative value for SVG.Number are now calculated in its morph method (related Sort out leftovers from the old fx module #547)Fix TBox Fix TBox #594bbox()
can be augmented with a method to get the transformed vectors (see Fix TBox #594 for motivation)The text was updated successfully, but these errors were encountered: