New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up render.js #61

Merged

woutdp merged 1 commit into woutdp:master from vonagam:clean-render-function

Jul 31, 2023

Contributor

vonagam commented Jul 31, 2023 •

edited

Currently props and slots are always passed from server side so no need for default values, they are never applied.
There should be no need to delete require.cache because elixir-nodejs does it already on every call.
Object.fromEntries will always return an object so || {} is not needed after the call.
context is already new Map() by default so can be removed from options.


          Clean up render.js

7a18fe7

Owner

woutdp commented Jul 31, 2023

Great improvement! I remember needing the delete require.cache code before but it seems to work without it now :)

woutdp merged commit 11adc1a into woutdp:master

vonagam deleted the clean-render-function branch

July 31, 2023 17:29

woutdp mentioned this pull request

Mark esbuild as dev only dependency #62

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment