Add socket prop to skip ssr for live mounts and navigation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutdp
reviewed
Aug 18, 2023
| {k, _v} -> k not in [:__changed__, :__given__, :ssr] | ||
| _ -> false | ||
| end) | ||
| props = Map.drop(assigns, [:__changed__, :__given__, :ssr, :class, :socket]) |
woutdp
reviewed
Aug 18, 2023
vonagam
force-pushed
the
add-socket-prop
branch
from
1678797
to
db73a57
Compare
|
Available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.
Added
socketprop and updated views in example project to use it. Sigil uses it automatically.Removed
get_ssrutil method.In generated live components
classwas not removed from props andsvelte_optswere even though they are not used there. Fixed.