Use setuptools instead of distutils #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen headers are data files and should reside inside the package
- use [setuptools_scm](https://pypi.python.org/pypi/setuptools_scm) to retrieve package's version from git tags - only install headers in eigency/eigen_3.2.8/Eigen directory - specify numpy and cython as install requirements - retrieve location of Eigen include directory using setuptool's [ResourceManager API])https://setuptools.readthedocs.io/en/latest/pkg_resources.html#resourcemanager-api)
Ignore files automatically generated by Cython and setuptools
|
@sebp Thanks for putting in the work to move eigency to setuptools. Looks great. Before accepting the PR, I'll just test out this new setup in the projects where I use eigency to see if there are any issues with this transition that I should be aware of. I should have some time the coming days. |
|
I just went through your proposed changes. Very nicely done. Thanks. I've merged, and released a new version to pypi (1.74). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usage of distutils by setuptools, as suggested in #8.
Changes