Use oldest-supported-numpy for building #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Can you update your fork with my recent bugfix to the master branch that fixes the failing pre-commit check? I'm not sure why GitHub isn't automatically re-running the checks against the merged result of this PR. |
|
Sure, updated branch with your fix. Thanks for looking into it! |
|
I'll release a new version on PyPi later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a problem that Eigency currently uses latest NumPy for building, however, it should use oldest supported NumPy version. Noticed it while debugging segmentation fault in a project using Eigency, it turned out that Eigency is built against latest NumPy from pip (right now 1.23.3), however, if system/venv has older NumPy, it can lead to crash due to ABI incompatibility (system/venv Numpy version must be always the same or greater than NumPy used for building).
More detailed and clearer explanation is at NumPy webpage:
https://numpy.org/doc/stable/user/depending_on_numpy.html#adding-a-dependency-on-numpy
This pull request changes the behavior to use oldest-supported-numpy as suggested by NumPy documentation.