Fix migrator #37
Merged
Fix migrator #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
added a commit
to theofidry/AliceDataFixtures
that referenced
this pull request
Nov 5, 2016
- Simplify the Travis build (closes #20) - Add tests for Ocramius ProxyManager support (closes #16) - Upgraded to Eloquent ~5.3.0 (required by WouterJEloquentBundle) - The Eloquent bridge requires wouterj/WouterJEloquentBundle#37 to work
|
Does this only apply to master, or also to 0.3.x? |
|
Master only, from what I can see you upgraded illuminate/database only there. Although the lack of tests for it applies for previous versions I believe |
|
👍 Thanks again |
|
Works like a charm https://travis-ci.org/theofidry/AliceDataFixtures/builds/173714099 |
|
Cool! Thanks for catching this one. And yes, tests are missing in older versions as well, but I'm ignoring that for now. The 0.x versions are just steps towards 1.0.0 imo, so I prefer not to do too much backporting. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprise to see there is no bug failing, I didn't look much into it, but while updating https://github.com/theofidry/AliceDataFixtures I face an issue during the migration reset as it doesn't find the migrations to rollback. You can see here why: it assumes the array of files gotten will have the migration name as an index.