Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform GeoPoint to plain object #56

Merged
merged 6 commits into from
Jun 26, 2019

Conversation

mamodom
Copy link
Collaborator

@mamodom mamodom commented Jun 21, 2019

closes #48
I think this is kind of a hack, but it's what's being done with
firestore timestamps. You can find more information about this issue
here

closes #48
I think this is kind of a hack, but it's what's being done with
firestore timestamps. You can find more information about this issue
[here](typestack/class-transformer#174)
@mamodom mamodom requested a review from wovalle June 21, 2019 23:45
@wovalle
Copy link
Owner

wovalle commented Jun 24, 2019

  • Explore the idea of exporting two (or one generic) decorator to transform geopoints and timestamps
  • Reuse decorator in tests, get rid of class transformer's @type

@mamodom
Copy link
Collaborator Author

mamodom commented Jun 26, 2019

LGTM

@wovalle wovalle mentioned this pull request Jun 26, 2019
5 tasks
@wovalle wovalle merged commit 24a64c9 into master Jun 26, 2019
@wovalle wovalle deleted the bug/error-retieving-geopoint branch June 26, 2019 20:20
@whateverbot
Copy link
Collaborator

🎉 This PR is included in version 0.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error retrieving document with GeoPoint type field
4 participants