refactor: ♻️ Drop isValidEvent
redundant function
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Util.isValidEvent
function.Description
This function is being executed before searching for duplicates, but seems to me that could lead to silent failures and does not contribute anything.
Motivation and Context
The example in documentation suggest to use this action when issues are
opened
oredited
. Doesn't makes sense to execute it on other contexts. So why this is being checked in the action? If at least the action would tell the user that is executing the action in an invalid event, but is not the case.If Github changes his payload the action just runs witout noticing anything. That's the problem we're running into in simple-icons, the action runs but doesn't do anything on certain issues. I'm having troubles debugging this.
Types of changes
Self Check before Merge