Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ Drop isValidEvent redundant function #21

Closed
wants to merge 1 commit into from

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Feb 4, 2022

Remove Util.isValidEvent function.

Description

This function is being executed before searching for duplicates, but seems to me that could lead to silent failures and does not contribute anything.

Motivation and Context

The example in documentation suggest to use this action when issues are opened or edited. Doesn't makes sense to execute it on other contexts. So why this is being checked in the action? If at least the action would tell the user that is executing the action in an invalid event, but is not the case.

If Github changes his payload the action just runs witout noticing anything. That's the problem we're running into in simple-icons, the action runs but doesn't do anything on certain issues. I'm having troubles debugging this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mondeja mondeja changed the title refactor: ♻️ Drop isValidEvent redundant function refactor: ♻️ Drop isValidEvent redundant function Feb 4, 2022
@mondeja mondeja closed this Jun 13, 2024
@mondeja mondeja deleted the remove-isValidEvent branch June 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant