Merge pull request #12 from wow-apps/3.2.13

3.2.13 (view CHANGELOG.md)

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [3.2.13] - 2018-12-21
+### Changed
+- Fixed characters replacement for links in trait ([Issue #11](https://github.com/wow-apps/symfony-slack-bot/issues/11))
+
 ## [3.2.12] - 2018-10-09
 ### Changed
 - Fixed setting of message icon ([Issue #9](https://github.com/wow-apps/symfony-slack-bot/issues/9))

Command/WowappsSlackbotTestCommand.php

@@ -120,6 +120,7 @@ private function drawConfig(SymfonyStyle $symfonyStyle, array $slackBotConfig)
 
     /**
      * @return bool
+     * @throws \ReflectionException
      */
     private function sendTestMessage()
     {
@@ -146,7 +147,7 @@ private function sendTestMessage()
             ->setShowQuote(true)
             ->setQuoteType(SlackBot::QUOTE_SUCCESS)
             ->setQuoteText($this->inlineMultilines($quoteText))
-            ->setQuoteTitle('SlackBot for Symfony 3')
+            ->setQuoteTitle('SlackBot for Symfony')
             ->setQuoteTitleLink('https://github.com/wow-apps/symfony-slack-bot')
         ;
 

README.md

@@ -87,18 +87,13 @@ To test your configuration, send test message by next command:
 ![Test command result preview](http://cdn.wow-apps.pro/slackbot/slackbot_preview-v2.jpg)
 
 
-# Documentation
-
-* [Home](https://github.com/wow-apps/symfony-slack-bot/wiki)
-    * [Installation](https://github.com/wow-apps/symfony-slack-bot/wiki/1.-Installation)
-    * [Using SlackBot](https://github.com/wow-apps/symfony-slack-bot/wiki/2.-Using-SlackBot)
-    * [Additional helpers](https://github.com/wow-apps/symfony-slack-bot/wiki/3.-Additional-helpers)
+# [Documentation](https://wow-apps.github.io/symfony-slack-bot/docs/#/)
 
-# News and updates:
+# News and updates
 
 Follow news and updates in my Telegram channel [@wow_apps_pro](https://t.me/wow_apps_pro) or Twitter [@alexey_samara_](https://twitter.com/alexey_samara_)
 
-# Say thanks:
+# Say thanks
 
 I don't ask for donates, I do what I do for free, for all development community. But I will be grateful if you inform me on the email in which project you are using this Bundle, as well as I will be glad to criticize and suggestions. 
 
@@ -133,6 +128,7 @@ Do you want to make a change? Pull requests are welcome.
 * [3.1.0] Missing phpDocs
 
 ## Changed
+* [3.2.13] Fixed characters replacement for links in trait ([Issue #11](https://github.com/wow-apps/symfony-slack-bot/issues/11))
 * [3.2.12] Fixed setting of message icon ([Issue #9](https://github.com/wow-apps/symfony-slack-bot/issues/9))
 * [3.2.12] Functions `setIcon` and `getIcon` for SlackBot DTO set as deprecated and will be removed in version 3.3 ([Issue #9](https://github.com/wow-apps/symfony-slack-bot/issues/9))
 * [3.2.12] Test command now send message with random emoji as icon

Tests/Traits/SlackMessageTraitTest.php

@@ -148,8 +148,6 @@ public function testEscapeCharacters()
     {
         $expect = $testString = $this->randomString() . '<&>';
         $expect = str_replace('&', '&amp;', $expect);
-        $expect = str_replace('<', '&lt;', $expect);
-        $expect = str_replace('>', '&gt;', $expect);
         $actual = $this->escapeCharacters($testString);
 
         $this->assertEquals($expect, $actual);

Traits/SlackMessageTrait.php

@@ -137,14 +137,11 @@ public function formatLink(string $title, string $url): string
     /**
      * @param string $string
      * @return string
+     * @deprecated
      * @see https://github.com/wow-apps/symfony-slack-bot/wiki/3.-Additional-helpers#escape-special-characters
      */
     public function escapeCharacters(string $string): string
     {
-        $string = str_replace('&', '&', $string);
-        $string = str_replace('<', '&lt;', $string);
-        $string = str_replace('>', '&gt;', $string);
-
-        return $string;
+        return str_replace('&', '&amp;', $string);
     }
 }