Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site footer: Creative Commons icons do not show #1931

Closed
iiegn opened this issue Nov 6, 2020 · 1 comment · Fixed by #1932
Closed

Site footer: Creative Commons icons do not show #1931

iiegn opened this issue Nov 6, 2020 · 1 comment · Fixed by #1932
Milestone

Comments

@iiegn
Copy link
Contributor

iiegn commented Nov 6, 2020

For me, the optional CC icons of the site footer do not work (404 errors). Looking at the Creative Commons Site, I would suggest a different set of URL:

https://github.com/wowchemy/wowchemy-hugo-modules/blob/80fce98e72a9da4e41dcc36cc58bed615dfecc39/wowchemy/layouts/partials/site_footer_license.html#L32-L40

-      <img src="https://search.creativecommons.org/static/img/cc_icon.svg" alt="CC icon">
-      <img src="https://search.creativecommons.org/static/img/cc-by_icon.svg" alt="CC by icon">
+      <img src="https://mirrors.creativecommons.org/presskit/icons/cc.svg" alt="CC icon">
+      <img src="https://mirrors.creativecommons.org/presskit/icons/by.svg" alt="CC by icon">
       {{ if not $allow_commercial }}
-        <img src="https://search.creativecommons.org/static/img/cc-nc_icon.svg" alt="CC NC icon">
+        <img src="https://mirrors.creativecommons.org/presskit/icons/nc.svg" alt="CC NC icon">
       {{end}}
       {{ if and $allow_derivatives $share_alike }}
-        <img src="https://search.creativecommons.org/static/img/cc-sa_icon.svg" alt="CC SA icon">
+        <img src="https://mirrors.creativecommons.org/presskit/icons/sa.svg" alt="CC SA icon">
       {{ else if not $allow_derivatives }}
-        <img src="https://search.creativecommons.org/static/img/cc-nd_icon.svg" alt="CC ND icon">
+        <img src="https://mirrors.creativecommons.org/presskit/icons/nd.svg" alt="CC ND icon">
iiegn added a commit to iiegn/iiegn.eu-hugo-wowchemy-site that referenced this issue Nov 6, 2020
@gcushen
Copy link
Collaborator

gcushen commented Nov 6, 2020

Thanks. Appears the URLs changed (perhaps as we were using their new beta). Feel free to submit a PR.

@gcushen gcushen added the bug label Nov 6, 2020
@gcushen gcushen added this to the v5.0 - Refresh :D milestone Nov 6, 2020
iiegn added a commit to iiegn/iiegn.eu-hugo-wowchemy-site that referenced this issue Nov 6, 2020
HugoBlox/hugo-blox-builder#1931

It seems, we can get the CC icons from the FA icon pack.
iiegn added a commit to iiegn/wowchemy-hugo-modules that referenced this issue Nov 6, 2020
The current CC icons, e.g.
 - `<img src="https://search.creativecommons.org/static/img/cc_icon.svg" alt="CC icon">`
result in 404 errors.

[Creative Commons Site](https://creativecommons.org/about/downloads/)
suggests something like
 - `<img src="https://mirrors.creativecommons.org/presskit/icons/cc.svg" alt="CC icon">`

But it seems, we can get the CC icons from the fab icon pack, which
seems even better.

Fix HugoBlox#1931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants