Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server configuration on server start #36

Merged
merged 5 commits into from
Jul 7, 2015

Conversation

petersandor
Copy link
Contributor

This is an improved version of #35

  • User is prompted for settings on npm start instead of during build process
  • ServerConfig wrapper class added to access settings functionality (currently extended with the initial setup function only)
  • No replacing is occuring, all settings are loaded on-demand
  • Includes a fix in tracking src/lib and src/spec folders

node_modules/
public/scripts/
public/styles/
public/templates/
spec/
/spec/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue with these on Windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not Windows specific, see docs

A leading slash matches the beginning of the pathname.
For example, "/*.c" matches "cat-file.c" but not "mozilla-sha1/sha1.c".

See for similar scenario http://stackoverflow.com/questions/24139478/when-to-use-leading-slash-in-gitignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it ended up ignoring src/lib and src/spec? If so, yikes! 😮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I found out once after I've added new files in src/lib

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic find, have adjusted blizzardry and some other repos accordingly! 👍

Could you prefix the other directories, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 55363d0

timkurvers added a commit that referenced this pull request Jul 7, 2015
Server configuration on server start
@timkurvers timkurvers merged commit 642e84c into wowserhq:master Jul 7, 2015
@timkurvers
Copy link
Member

Woo, superb! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants