Startup instructions updated, removed references to data folder #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User is prompted to provide path to client data folder and other settings on first startup
| if (process.platform === 'win32') { | ||
| return 'C:/Program Files (x86)/World of Warcraft/Data' | ||
| } | ||
| else { |
There was a problem hiding this comment.
Could you add the brace and the else on the same line? Other than that, looks stellar! 👍
There was a problem hiding this comment.
Nice catch, fixed in 9d603df
|
Great stuff 👍 |
timkurvers
added a commit
that referenced
this pull request
Jul 7, 2015
Startup instructions updated, removed references to data folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨